rearranging fruit is an example of greedy algorithm #13291
Conversation
Create coin_change_II.py
example of a greedy algorithm
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| from typing import List | ||
|
|
||
| class Solution: | ||
| def change(self, amount: int, coins: List[int]) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/coin_change_II.py, please provide doctest for the function change
| class Solution: | ||
| def change(self, amount: int, coins: List[int]) -> int: | ||
| cache = {} | ||
| def dfs(i,a): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file dynamic_programming/coin_change_II.py, please provide doctest for the function dfs
Please provide return type hint for the function: dfs. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the parameter: i
Please provide type hint for the parameter: i
Please provide descriptive name for the parameter: a
Please provide type hint for the parameter: a
| @@ -0,0 +1,22 @@ | |||
| class Solution: | |||
| def minCost(self, basket1: List[int], basket2: List[int]) -> int: | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file greedy_methods/rearranging_fruits.py, please provide doctest for the function minCost
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: minCost
algorithms-keeper
bot
removed
require descriptive names
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,22 @@ | |||
| class Solution: | |||
| def minCost(self, basket1: List[int], basket2: List[int]) -> int: | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file greedy_methods/rearranging_fruits.py, please provide doctest for the function minCost
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: minCost
for more information, see https://pre-commit.ci
Update rearranging_fruits.py
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| from collections import defaultdict | ||
|
|
||
| class Solution: | ||
| def minCost(self, basket1: List[int], basket2: List[int]) -> int: |
There was a problem hiding this comment.
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: minCost
As there is no test file in this pull request nor any test function or class in the file greedy_methods/rearranging_fruits.py, please provide doctest for the function minCost
for more information, see https://pre-commit.ci
Describe your change:
Checklist: